linux-kernel - RE: [PATCH v3 1/3] media: uapi: v4l: Change V4L2_TYPE_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SL2P216MB1246EAAFD8C5B220CDBD385BFBD42@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
Date: Mon, 24 Jun 2024 09:45:27 +0000
From: Nas Chung <nas.chung@...psnmedia.com>
To: "hverkuil@...all.nl" <hverkuil@...all.nl>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: RE: [PATCH v3 1/3] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
 condition

Hi, Hans.

Gentle ping on this patch series.

To recap, the previous feedback included
- Adding a comment after "V4L2_BUF_TYPE_META_OUTPUT	   = 14,"
- Fixing a build warning in the venus/vdec.c code
- Removing V4L2_BUF_TYPE_VIDEO_OVERLAY in V4L2_TYPE_IS_OUTPUT()

I have addressed these points in the latest version of the patch series.

Thanks.
Nas.

>-----Original Message-----
>From: Nas Chung <nas.chung@...psnmedia.com>
>Sent: Tuesday, June 4, 2024 2:11 PM
>To: mchehab@...nel.org; hverkuil@...all.nl; bryan.odonoghue@...aro.org;
>linux-media@...r.kernel.org
>Cc: linux-kernel@...r.kernel.org; Nas Chung <nas.chung@...psnmedia.com>;
>Michael Tretter <m.tretter@...gutronix.de>
>Subject: [PATCH v3 1/3] media: uapi: v4l: Change V4L2_TYPE_IS_CAPTURE
>condition
>
>Explicitly compare a buffer type only with valid buffer types,
>to avoid matching a buffer type outside of the valid buffer type set.
>
>Signed-off-by: Nas Chung <nas.chung@...psnmedia.com>
>Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>
>---
>v3
>- Address Han's feedback
>
>v2
>- Improve commit message
>- Add V4L2_TYPE_IS_VALID(type) macro
>
> include/uapi/linux/videodev2.h | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/include/uapi/linux/videodev2.h
>b/include/uapi/linux/videodev2.h
>index fe6b67e83751..51da63173a98 100644
>--- a/include/uapi/linux/videodev2.h
>+++ b/include/uapi/linux/videodev2.h
>@@ -153,10 +153,17 @@ enum v4l2_buf_type {
> 	V4L2_BUF_TYPE_SDR_OUTPUT           = 12,
> 	V4L2_BUF_TYPE_META_CAPTURE         = 13,
> 	V4L2_BUF_TYPE_META_OUTPUT	   = 14,
>+	/*  V4L2_TYPE_IS_VALID and V4L2_TYPE_IS_OUTPUT must
>+	 *  be updated if a new type is added.
>+	 */
> 	/* Deprecated, do not use */
> 	V4L2_BUF_TYPE_PRIVATE              = 0x80,
> };
>
>+#define V4L2_TYPE_IS_VALID(type)		\
>+	((type) >= V4L2_BUF_TYPE_VIDEO_CAPTURE	\
>+	 && (type) <= V4L2_BUF_TYPE_META_OUTPUT)
>+
> #define V4L2_TYPE_IS_MULTIPLANAR(type)			\
> 	((type) == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE	\
> 	 || (type) == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
>@@ -171,7 +178,8 @@ enum v4l2_buf_type {
> 	 || (type) == V4L2_BUF_TYPE_SDR_OUTPUT			\
> 	 || (type) == V4L2_BUF_TYPE_META_OUTPUT)
>
>-#define V4L2_TYPE_IS_CAPTURE(type) (!V4L2_TYPE_IS_OUTPUT(type))
>+#define V4L2_TYPE_IS_CAPTURE(type)	\
>+	(V4L2_TYPE_IS_VALID(type) && !V4L2_TYPE_IS_OUTPUT(type))
>
> enum v4l2_tuner_type {
> 	V4L2_TUNER_RADIO	     = 1,
>--
>2.25.1