linux-kernel - Re: [PATCH V2] arm64: dts: qcom: x1e80100: Add fastrpc nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cc374b8-ebf2-0dde-2733-bb188e6591de@quicinc.com>
Date: Mon, 24 Jun 2024 15:29:57 +0530
From: Sibi Sankar <quic_sibis@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <andersson@...nel.org>,
        <krzk+dt@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <conor+dt@...nel.org>,
        <dmitry.baryshkov@...aro.org>, <abel.vesa@...aro.org>,
        <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH V2] arm64: dts: qcom: x1e80100: Add fastrpc nodes



On 6/19/24 00:45, Konrad Dybcio wrote:
> 
> 
> On 6/18/24 16:56, Sibi Sankar wrote:
>> Add fastrpc nodes for ADSP and CDSP on X1E80100 SoC.
>>
>> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>

Hey Konrad,
Thanks for taking time to review the series :)

>> ---
> 
> [...]
> 
>> +
>> +                    compute-cb@1 {
>> +                        compatible = "qcom,fastrpc-compute-cb";
>> +                        reg = <1>;
>> +                        iommus = <&apps_smmu 0x0c01 0x20>,
>> +                             <&apps_smmu 0x0c21 0x20>;
> 
> (0x0c01 & ~0x20) == (0x0c21 & ~0x20), is this repetition required by
> the firmware, or would it work with the latter entry dropped? (and
> all others in this cdsp fastrpc list)

Yes the latter can/should be dropped. Thanks for catching this. Will
fix this in the next re-spin.

-Sibi

> 
> Konrad