linux-kernel - Re: [PATCH v2 5/8] Add debug log info to camss_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18df8577-5268-4a36-83fe-7cd7a7bbb7d3@linaro.org>
Date: Mon, 24 Jun 2024 11:07:23 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: gchan9527@...il.com, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, cros-qcom-dts-watchers@...omium.org,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/8] Add debug log info to camss_enable_clocks function

On 24/06/2024 00:22, George Chan via B4 Relay wrote:
> From: George Chan <gchan9527@...il.com>
> 
> Print out missing clock's name when doing camss_enable_clocks().
> 
> Signed-off-by: George Chan <gchan9527@...il.com>
> ---
>   drivers/media/platform/qcom/camss/camss.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 86ba80c47188..d50f98565531 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1467,7 +1467,7 @@ int camss_enable_clocks(int nclocks, struct camss_clock *clock,
>   	for (i = 0; i < nclocks; i++) {
>   		ret = clk_prepare_enable(clock[i].clk);
>   		if (ret) {
> -			dev_err(dev, "clock enable failed: %d\n", ret);
> +			dev_err(dev, "clock enable failed: %s %d\n", clock[i].name, ret);
>   			goto error;
>   		}
>   	}
> 

Acked-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>