linux-kernel - Re: [PATCH] m68k: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 12:11:49 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] m68k: add missing MODULE_DESCRIPTION() macros

Hi Jeff,

On Tue, Jun 18, 2024 at 4:46 PM Jeff Johnson <quic_jjohnson@...cinc.com> wrote:
> On 6/18/2024 12:36 AM, Geert Uytterhoeven wrote:
> > On Tue, Jun 18, 2024 at 1:47 AM Jeff Johnson <quic_jjohnson@...cinc.com> wrote:
> >> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
> >> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o
> >>
> >> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> >>
> >> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> >
> > Thanks for your patch!
> >
> >> --- a/arch/m68k/emu/nfblock.c
> >> +++ b/arch/m68k/emu/nfblock.c
> >> @@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
> >>  module_init(nfhd_init);
> >>  module_exit(nfhd_exit);
> >>
> >> +MODULE_DESCRIPTION("ARAnyM block device driver");
> >
> > I think that should be s/ARAnyM/Atari NatFeat/, as I believe NatFeat
> > is also available on other Atari emulators. See also nfeth.c
> >
> >>  MODULE_LICENSE("GPL");
> >> diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
> >> index 17b2987c2bf5..0ab2e4d08871 100644
> >> --- a/arch/m68k/emu/nfcon.c
> >> +++ b/arch/m68k/emu/nfcon.c
> >> @@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
> >>  module_init(nfcon_init);
> >>  module_exit(nfcon_exit);
> >>
> >> +MODULE_DESCRIPTION("ARAnyM console driver");
> >
> > Likewise.
> >
> >>  MODULE_LICENSE("GPL");
> >
> > If you agree, I can make these changes while queuing in the m68k tree
> > for v6.11.
>
> You are the domain expert here. I'd be very happy for you to make the changes :)

I made these changes while applying your patch. No need to resend.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds