linux-kernel - Re: [PATCH v2 6/8] Add debug log info to msm_csid_subdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76783b25-89cd-4bd2-a333-7ed2a6be065a@kernel.org>
Date: Mon, 24 Jun 2024 12:19:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, gchan9527@...il.com,
 Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, cros-qcom-dts-watchers@...omium.org,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/8] Add debug log info to msm_csid_subdev_init
 function

On 24/06/2024 12:08, Bryan O'Donoghue wrote:
> On 24/06/2024 00:22, George Chan via B4 Relay wrote:
>> +			dev_err(dev, "missing clk %s", res->clock[i]);
> 
> Please don't abbreviate - the other error message says "clock" here we 
> say "clk"
> 

Is it a probe path? If yes, then this should be dev_err_probe. If not,
then are you sure that non-probe paths should acquire resources? How
does it handle deferred probe in such case?

Best regards,
Krzysztof