linux-kernel - Re: [PATCH v1] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6bbb201-55a0-4630-a01f-fedae8d2eb96@kernel.org>
Date: Mon, 24 Jun 2024 12:30:14 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Waiman Long <longman@...hat.com>, tj@...nel.org, cgroups@...r.kernel.org,
 yosryahmed@...gle.com, shakeel.butt@...ux.dev
Cc: hannes@...xchg.org, lizefan.x@...edance.com, kernel-team@...udflare.com,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] cgroup/rstat: Avoid thundering herd problem by kswapd
 across NUMA nodes


On 21/06/2024 17.13, Waiman Long wrote:
> On 6/21/24 10:47, Jesper Dangaard Brouer wrote:
>>
>> Hold off applying this patch, as test kernel didn't boot with this patch
>> applied on top of TJ's cgroup tree (on commit ec9eeb89e60d86).  I don't
>> know if this is related to this patch or not.
> 
> Commit ec9eeb89e60d86 is just a snapshot of the Linus' tree. You should 
> use for-next/for-6.11 tag as a base.

Patch works fine when applied on branch for-6.11.
(This snapshot of the Linus' tree seems to be at fault).

I would still like feedback on, if this code (for detecting "root" cgrp) 
is correct? :

  static inline bool cgroup_is_root(struct cgroup *cgrp)
  {
	return cgroup_parent(cgrp) == NULL;
  }


Next step for me is to backport and deploy this on a subset of 
production servers.

--Jesper