linux-kernel - Re: [PATCH] platform/x86/siemens: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7941463e-1d2c-4d5a-a772-bf8f60db58a7@redhat.com>
Date: Mon, 24 Jun 2024 13:33:55 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>,
 Gerd Haeussler <gerd.haeussler.ext@...mens.com>,
 Xing Tong Wu <xingtong.wu@...mens.com>,
 Tobias Schaffner <tobias.schaffner@...mens.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] platform/x86/siemens: add missing MODULE_DESCRIPTION()
 macros

Hi,

On 6/12/24 6:25 AM, Jeff Johnson wrote:
> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/siemens/simatic-ipc.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/siemens/simatic-ipc-batt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans


> ---
>  drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.c  | 1 +
>  drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.c | 1 +
>  drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c      | 1 +
>  drivers/platform/x86/siemens/simatic-ipc-batt.c             | 1 +
>  drivers/platform/x86/siemens/simatic-ipc.c                  | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.c b/drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.c
> index 31a139d87d9a..5edc294de6e4 100644
> --- a/drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.c
> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt-apollolake.c
> @@ -45,6 +45,7 @@ static struct platform_driver simatic_ipc_batt_driver = {
>  
>  module_platform_driver(simatic_ipc_batt_driver);
>  
> +MODULE_DESCRIPTION("CMOS Battery monitoring for Simatic IPCs based on Apollo Lake GPIO");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:" KBUILD_MODNAME);
>  MODULE_SOFTDEP("pre: simatic-ipc-batt platform:apollolake-pinctrl");
> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.c b/drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.c
> index a7676f224075..e6a56d14b505 100644
> --- a/drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.c
> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt-elkhartlake.c
> @@ -45,6 +45,7 @@ static struct platform_driver simatic_ipc_batt_driver = {
>  
>  module_platform_driver(simatic_ipc_batt_driver);
>  
> +MODULE_DESCRIPTION("CMOS Battery monitoring for Simatic IPCs based on Elkhart Lake GPIO");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:" KBUILD_MODNAME);
>  MODULE_SOFTDEP("pre: simatic-ipc-batt platform:elkhartlake-pinctrl");
> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c b/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c
> index 5e77e05fdb5d..f8849d0e48a8 100644
> --- a/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c
> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt-f7188x.c
> @@ -81,6 +81,7 @@ static struct platform_driver simatic_ipc_batt_driver = {
>  
>  module_platform_driver(simatic_ipc_batt_driver);
>  
> +MODULE_DESCRIPTION("CMOS Battery monitoring for Simatic IPCs based on Nuvoton GPIO");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:" KBUILD_MODNAME);
>  MODULE_SOFTDEP("pre: simatic-ipc-batt gpio_f7188x platform:elkhartlake-pinctrl platform:alderlake-pinctrl");
> diff --git a/drivers/platform/x86/siemens/simatic-ipc-batt.c b/drivers/platform/x86/siemens/simatic-ipc-batt.c
> index c6dd263b4ee3..d9aff10608cf 100644
> --- a/drivers/platform/x86/siemens/simatic-ipc-batt.c
> +++ b/drivers/platform/x86/siemens/simatic-ipc-batt.c
> @@ -247,6 +247,7 @@ static struct platform_driver simatic_ipc_batt_driver = {
>  
>  module_platform_driver(simatic_ipc_batt_driver);
>  
> +MODULE_DESCRIPTION("CMOS core battery driver for Siemens Simatic IPCs");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:" KBUILD_MODNAME);
>  MODULE_AUTHOR("Henning Schild <henning.schild@...mens.com>");
> diff --git a/drivers/platform/x86/siemens/simatic-ipc.c b/drivers/platform/x86/siemens/simatic-ipc.c
> index 8ca6e277fa03..7039874d8f11 100644
> --- a/drivers/platform/x86/siemens/simatic-ipc.c
> +++ b/drivers/platform/x86/siemens/simatic-ipc.c
> @@ -231,6 +231,7 @@ static void __exit simatic_ipc_exit_module(void)
>  module_init(simatic_ipc_init_module);
>  module_exit(simatic_ipc_exit_module);
>  
> +MODULE_DESCRIPTION("Siemens SIMATIC IPC platform driver");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Gerd Haeussler <gerd.haeussler.ext@...mens.com>");
>  MODULE_ALIAS("dmi:*:svnSIEMENSAG:*");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240611-md-drivers-platform-x86-siemens-9e7c20b9ca24
>