linux-kernel - Re: [net PATCH 1/7] octeontx2-af: Fix klockwork issue in cgx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 14:11:36 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Suman Ghosh <sumang@...vell.com>, netdev@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jerin Jacob <jerinj@...vell.com>, Eric Dumazet <edumazet@...gle.com>,
 Geethasowjanya Akula <gakula@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>, Linu Cherian <lcherian@...vell.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [net PATCH 1/7] octeontx2-af: Fix klockwork issue in cgx.c

> Fix minor klockwork issue in CGX. These are not real issues but sanity checks.

Please improve your change descriptions considerably.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n45

…
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c
> @@ -465,6 +465,13 @@ u64 cgx_lmac_addr_get(u8 cgx_id, u8 lmac_id)
>  	u64 cfg;
>  	int id;
>
> +	if (!cgx_dev)
> +		return 0;
> +
> +	lmac = lmac_pdata(lmac_id, cgx_dev);
> +	if (!lmac)
> +		return 0;
> +
>  	mac_ops = cgx_dev->mac_ops;
>
>  	id = get_sequence_id_of_lmac(cgx_dev, lmac_id);
> @@ -1648,7 +1655,7 @@ unsigned long cgx_get_lmac_bmap(void *cgxd)
>  static int cgx_lmac_init(struct cgx *cgx)
>  {
>  	struct lmac *lmac;
> -	u64 lmac_list;
> +	u64 lmac_list = 0;
>  	int i, err;
>
>  	/* lmac_list specifies which lmacs are enabled

Did you mix software development concern categories here?

Please reconsider your selection of change combinations once more.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n168

Regards,
Markus