linux-kernel - Re: [PATCH v4] drivers: rtc: Add driver for SD2405AL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de896abc-aa93-4886-a414-ad992605ba91@prolan.hu>
Date: Mon, 24 Jun 2024 15:30:25 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: <gomba007@...il.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>
CC: <linux-kernel@...r.kernel.org>, <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH v4] drivers: rtc: Add driver for SD2405AL.

Hi!
As per my last email,

On 6/24/24 13:25, Tóth János via B4 Relay wrote:
> From: Tóth János <gomba007@...il.com>
> 
> Add support for the DFRobot SD2405AL I2C RTC Module.
> 
> Datasheet:
> 	https://image.dfrobot.com/image/data/TOY0021/SD2405AL%20datasheet%20(Angelo%20v0.1).pdf
> 
> Product:
> 	https://www.dfrobot.com/product-1600.html
> 
> To instantiate (assuming device is connected to I2C-1)
> as root:
> 	echo sd2405al 0x32 > /sys/bus/i2c/devices/i2c-1/new_device
> as user:
> 	echo 'sd2405al 0x32' | sudo tee /sys/class/i2c-adapter/i2c-1/new_device
> 
> The driver is tested with:
> 	+ hwclock
> 	+ tools/testing/selftests/rtc/setdate
> 	+ tools/testing/selftests/rtc/rtctest
> 
> Signed-off-by: Tóth János <gomba007@...il.com>

Reviewed-by: Csókás, Bence <csokas.bence@...lan.hu>

 > ---
 > Changes in v4:
 > - Implement more comprehensive data validation.

BTW why did you decide to add this? Did you have problems with these 
high bits getting set?

Bence