linux-kernel - Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024062404-avoid-grieving-a3fa@gregkh>
Date: Mon, 24 Jun 2024 15:37:29 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Jacky Huang <ychuang570808@...il.com>
Cc: dan.carpenter@...aro.org, jirislaby@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node

On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@...oton.com>
> 
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
> 
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Jacky Huang <ychuang3@...oton.com>

You forgot a "Reported-by:" line as Dan did report this to you.

> ---
>  drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

Also, no info as to what changed from v1 :(

thanks,

greg k-h