linux-kernel - RE: [PATCH v3 2/5] mei: vsc: Enhance SPI transfer of IVSC rom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB760513EA18085ECE635A6606E5D42@PH7PR11MB7605.namprd11.prod.outlook.com>
Date: Mon, 24 Jun 2024 14:29:51 +0000
From: "Winkler, Tomas" <tomas.winkler@...el.com>
To: "Wu, Wentong" <wentong.wu@...el.com>, "sakari.ailus@...ux.intel.com"
	<sakari.ailus@...ux.intel.com>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, "Chen, Jason Z"
	<jason.z.chen@...el.com>
Subject: RE: [PATCH v3 2/5] mei: vsc: Enhance SPI transfer of IVSC rom

> Constructing the SPI transfer command as per the specific request.

Please provide "Why" , this is not straight forward to understand, also deserves a comment in code.

> 
> Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
> Cc: stable@...r.kernel.org # for 6.8+
> Signed-off-by: Wentong Wu <wentong.wu@...el.com>
> Tested-by: Jason Chen <jason.z.chen@...el.com>
> ---
>  drivers/misc/mei/vsc-tp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/vsc-tp.c b/drivers/misc/mei/vsc-tp.c index
> 5f3195636e53..26387e2f1dd7 100644
> --- a/drivers/misc/mei/vsc-tp.c
> +++ b/drivers/misc/mei/vsc-tp.c
> @@ -331,7 +331,7 @@ int vsc_tp_rom_xfer(struct vsc_tp *tp, const void
> *obuf, void *ibuf, size_t len)
>  		return ret;
>  	}
> 
> -	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, tp->rx_buf, len);
> +	ret = vsc_tp_dev_xfer(tp, tp->tx_buf, ibuf ? tp->rx_buf : NULL, len);
>  	if (ret)
>  		return ret;
> 
> --
> 2.34.1