linux-kernel - Re: [PATCH] drm/amd/display: Remove unused function reverse_planes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PzZMNmJGnxMh88owr59erSHaOZpgtwrVWjjdoNvC++YQ@mail.gmail.com>
Date: Mon, 24 Jun 2024 10:47:24 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	airlied@...il.com, daniel@...ll.ch, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm/amd/display: Remove unused function reverse_planes_order

On Mon, Jun 24, 2024 at 4:07 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> The function are defined in the amdgpu_dm.c file, but not called
> anywhere, so delete the unused function.
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:371:20: warning: unused function 'reverse_planes_order'.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9402
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 4b86b30eddc4..1e0e33b565f1 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -368,15 +368,6 @@ static inline bool is_dc_timing_adjust_needed(struct dm_crtc_state *old_state,
>                 return false;
>  }
>
> -static inline void reverse_planes_order(struct dc_surface_update *array_of_surface_update,
> -                                       int planes_count)
> -{
> -       int i, j;
> -
> -       for (i = 0, j = planes_count - 1; i < j; i++, j--)
> -               swap(array_of_surface_update[i], array_of_surface_update[j]);
> -}
> -
>  /*
>   * DC will program planes with their z-order determined by their ordering
>   * in the dc_surface_updates array. This comparator is used to sort them
> --
> 2.20.1.7.g153144c
>