linux-kernel - Re: [PATCH] drm/amd/display: use swap() in is_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OXp3mcy16bwSJYKj+KaFbAqRP6MqNLfre=bum8Jcz7EA@mail.gmail.com>
Date: Mon, 24 Jun 2024 10:55:31 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com, 
	alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	airlied@...il.com, daniel@...ll.ch, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm/amd/display: use swap() in is_config_schedulable()

Applied.  Thanks!

Alex

On Sun, Jun 23, 2024 at 10:22 PM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Use existing swap() function rather than duplicating its implementation.
>
> ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1171:103-104: WARNING opportunity for swap().
> ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1231:99-100: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9400
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  .../dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c  | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c
> index 7272a04b9d1d..926d45496e79 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c
> @@ -1158,7 +1158,6 @@ static bool is_config_schedulable(
>         schedulable = true;
>
>         /* sort disallow times from greatest to least */
> -       unsigned int temp;
>         for (i = 0; i < s->pmo_dcn4.num_timing_groups; i++) {
>                 bool swapped = false;
>
> @@ -1167,9 +1166,8 @@ static bool is_config_schedulable(
>                         double jp1_disallow_us = s->pmo_dcn4.group_common_fams2_meta[s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1]].disallow_time_us;
>                         if (j_disallow_us < jp1_disallow_us) {
>                                 /* swap as A < B */
> -                               temp = s->pmo_dcn4.sorted_group_gtl_disallow_index[j];
> -                               s->pmo_dcn4.sorted_group_gtl_disallow_index[j] = s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1];
> -                               s->pmo_dcn4.sorted_group_gtl_disallow_index[j + 1] = temp;
> +                               swap(s->pmo_dcn4.sorted_group_gtl_disallow_index[j],
> +                                    s->pmo_dcn4.sorted_group_gtl_disallow_index[j+1]);
>                                 swapped = true;
>                         }
>                 }
> @@ -1227,9 +1225,8 @@ static bool is_config_schedulable(
>                         double jp1_period_us = s->pmo_dcn4.group_common_fams2_meta[s->pmo_dcn4.sorted_group_gtl_period_index[j + 1]].period_us;
>                         if (j_period_us < jp1_period_us) {
>                                 /* swap as A < B */
> -                               temp = s->pmo_dcn4.sorted_group_gtl_period_index[j];
> -                               s->pmo_dcn4.sorted_group_gtl_period_index[j] = s->pmo_dcn4.sorted_group_gtl_period_index[j + 1];
> -                               s->pmo_dcn4.sorted_group_gtl_period_index[j + 1] = temp;
> +                               swap(s->pmo_dcn4.sorted_group_gtl_period_index[j],
> +                                    s->pmo_dcn4.sorted_group_gtl_period_index[j+1]);
>                                 swapped = true;
>                         }
>                 }
> --
> 2.20.1.7.g153144c
>