linux-kernel - Re: [PATCH v2] staging: rtl8192e: Fix conflicting types error with net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024062553-postbox-gangly-e155@gregkh>
Date: Tue, 25 Jun 2024 17:23:19 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Teddy Engel <engel.teddy@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, devel@...verdev.osuosl.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: Fix conflicting types error with
 net_device.

On Tue, Jun 25, 2024 at 04:19:18PM +0100, Teddy Engel wrote:
> Add a pre-declaration of struct net_device so the compiler is able to
> use rtl_pci.h / rtl_cam.h.
> 
> Fix for commit: 7dff0b27d9c842f88149bf611cbc0b59be1dcd3c:
> [34/59] staging: rtl89192e: Remove unnecessary pre-declaration of struct
> net_device.
> 
> Signed-off-by: Teddy Engel <engel.teddy@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406250858.L8rJMHQm-lkp@intel.com/
> ---
> v2: Add commit id that's being fixed.

You do that with a "Fixes:" tag, not the paragraph you wrote above :)

The documentation should explain how to do it, right?

thanks,

greg k-h