linux-kernel - Re: [PATCH 0/4] Verify devices transition from D3cold to D0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9436f1c-330b-469d-bb93-3e89102b09b9@amd.com>
Date: Tue, 25 Jun 2024 10:43:20 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Mathias Nyman <mathias.nyman@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>,
 "open list:USB XHCI DRIVER" <linux-usb@...r.kernel.org>,
 Daniel Drake <drake@...lessos.org>, Gary Li <Gary.Li@....com>
Subject: Re: [PATCH 0/4] Verify devices transition from D3cold to D0

On 6/19/2024 13:50, Mario Limonciello wrote:
> On 6/19/2024 00:29, Mika Westerberg wrote:
>> On Tue, Jun 18, 2024 at 11:56:50AM -0500, Mario Limonciello wrote:
>>> On 6/18/2024 08:14, Mika Westerberg wrote:
>>>> Hi Mario,
>>>>
>>>> On Thu, Jun 13, 2024 at 12:42:00AM -0500, Mario Limonciello wrote:
>>>>> Gary has reported that when a dock is plugged into a system at the 
>>>>> same
>>>>> time the autosuspend delay has tripped that the USB4 stack 
>>>>> malfunctions.
>>>>>
>>>>> Messages show up like this:
>>>>>
>>>>> ```
>>>>> thunderbolt 0000:e5:00.6: ring_interrupt_active: interrupt for TX 
>>>>> ring 0 is already enabled
>>>>> ```
>>>>>
>>>>> Furthermore the USB4 router is non-functional at this point.
>>>>
>>>> Once the USB4 domain starts the sleep transition, it cannot be
>>>> interrupted by anything so it always should go through full sleep
>>>> transition and only then back from sleep.
>>>>
>>>>> Those messages happen because the device is still in D3cold at the 
>>>>> time
>>>>> that the PCI core handed control back to the USB4 connection manager
>>>>> (thunderbolt).
>>>>
>>>> This is weird. Yes we should be getting the wake from the hotplug but
>>>> that should happen only after the domain is fully in sleep (D3cold). 
>>>> The
>>>> BIOS ACPI code is supposed to deal with this.
>>>
>>> Is that from from experience or do you mean there is a spec behavior?
>>>
>>> IE I'm wondering if we have different "expectations" from different
>>> company's hardware designers.
>>
>> The spec and the CM guide "imply" this behaviour as far as I can tell,
>> so that the "sleep event" is done completely once started. I guess this
>> can be interpreted differently too because it is not explicitly said
>> there.
>>
>> Can you ask AMD HW folks if this is their interpretation too? Basically
>> when we get "Sleep Ready" bit set for all the routers in the domain and
>> turn off power (send PERST) there cannot be wake events until that is
>> fully completed.
>>
>> There is typically a timeout mechanism in the BIOS side (part of the
>> power off method) that waits for the PCIe links to enter L2 before it
>> triggers PERST. We have seen an issue on our side that if this L2
>> transition is not completed in time a wake event triggered but that was
>> a BIOS issue.
> 
> Sure thing.  I'll discuss it with them and get back with the results.

 From the hardware team they describe this as an abnormal state that 
they don't expect.  I don't believe there is anything in the BIOS to 
prevent it though.

I could discuss options for this with the BIOS team in the future for 
the USB4 router ACPI device, but as this "seems" to be the same problem 
as XHCI controllers going back at least 5 generations with those quirks 
I put reverts in this series I think a general kernel solution to make 
"sure" that devices have transitioned is the better way to go.

> 
>>
>>>>> The issue is that it takes time for a device to enter D3cold and do a
>>>>> conventional reset, and then more time for it to exit D3cold.
>>>>>
>>>>> This appears not to be a new problem; previously there were very 
>>>>> similar
>>>>> reports from Ryzen XHCI controllers.  Quirks were added for those.
>>>>> Furthermore; adding extra logging it's apparent that other PCI devices
>>>>> in the system can take more than 10ms to recover from D3cold as well.
>>>>
>>>> They can take anything up to 100ms after the link has trained.
>>>
>>> Right; so currently there is nothing checking they really made it 
>>> back to D0
>>> after calling pci_power_up().  I feel like we've "mostly" gotten lucky.
>>
>> We do have pci_bridge_wait_for_secondary_bus() there but I guess that's
>> not called for integrated PCIe endpoints such as xHCI and the USB4 Host
>> Interface. They too enter D3cold once power is turned off so I agree we
>> might have gotten lucky here with the D3hot 10ms delay.
> 
> Yup; exactly.  I think when Gary found this he was seeing other 
> integrated devices not being ready in time too, but IIRC there wasn't 
> functional impact from them like there is on XHCI and USB4.
> 
> 

Bjorn,

Considering the above, can you please review this series?