linux-kernel - Re: [PATCH] Input: qt1050 - handle CHIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Znrs5QVAuSjH5sCT@google.com>
Date: Tue, 25 Jun 2024 09:14:29 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Andrei Lalaev <andrey.lalaev@...il.com>
Cc: robh@...nel.org, m.felsch@...gutronix.de, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrei Lalaev <andrei.lalaev@...on-paar.com>
Subject: Re: [PATCH] Input: qt1050 - handle CHIP_ID reading error

On Mon, Jun 17, 2024 at 08:30:18PM +0200, Andrei Lalaev wrote:
> From: Andrei Lalaev <andrei.lalaev@...on-paar.com>
> 
> If the device is missing, we get the following error:
> 
>   qt1050 3-0041: ID -1340767592 not supported
> 
> Let's handle this situation and print more informative error
> when reading of CHIP_ID fails:
> 
>   qt1050 3-0041: Failed to read chip ID: -6
> 
> Fixes: cbebf5addec1 ("Input: qt1050 - add Microchip AT42QT1050 support")
> Signed-off-by: Andrei Lalaev <andrei.lalaev@...on-paar.com>

Applied, thank you.

But how did we get into the situation with the chip being missing?
Incorrect DTB for the board?

Thanks.

-- 
Dmitry