linux-kernel - Re: [PATCH v8 02/10] filemap: allocate mapping_min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240625180609.z4prikqk7eufl6bi@quentin>
Date: Tue, 25 Jun 2024 18:06:09 +0000
From: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: david@...morbit.com, chandan.babu@...cle.com, djwong@...nel.org,
	brauner@...nel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, yang@...amperecomputing.com,
	linux-mm@...ck.org, john.g.garry@...cle.com,
	linux-fsdevel@...r.kernel.org, hare@...e.de, p.raghav@...sung.com,
	mcgrof@...nel.org, gost.dev@...sung.com, cl@...amperecomputing.com,
	linux-xfs@...r.kernel.org, hch@....de, Zi Yan <zi.yan@...t.com>
Subject: Re: [PATCH v8 02/10] filemap: allocate mapping_min_order folios in
 the page cache

On Tue, Jun 25, 2024 at 04:52:03PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 25, 2024 at 11:44:12AM +0000, Pankaj Raghav (Samsung) wrote:
> > Co-developed-by: Luis Chamberlain <mcgrof@...nel.org>
> > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> > Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
> > Reviewed-by: Hannes Reinecke <hare@...e.de>
> > Reviewed-by: Darrick J. Wong <djwong@...nel.org>
> 
> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Thanks!
> 
> after fixing the nits below
> 
> > +/**
> > + * mapping_align_index() - Align index based on the min
> > + * folio order of the page cache.
> 
> + * mapping_align_index - Align index for this mapping.
> 
> > @@ -1165,7 +1186,7 @@ static inline vm_fault_t folio_lock_or_retry(struct folio *folio,
> >  void folio_wait_bit(struct folio *folio, int bit_nr);
> >  int folio_wait_bit_killable(struct folio *folio, int bit_nr);
> >  
> > -/* 
> > +/*
> >   * Wait for a folio to be unlocked.
> >   *
> >   * This must be called with the caller "holding" the folio,
> 
> Unnecessary whitespace change
>