linux-kernel - Re: [PATCH v2 3/6] perf: build: Only link libebl.a for old libdw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 19:09:02 +0100
From: Leo Yan <leo.yan@....com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
 Ian Rogers <irogers@...gle.com>, James Clark <james.clark@....com>,
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>, Nick Terrell <terrelln@...com>,
 Thomas Richter <tmricht@...ux.ibm.com>, Quentin Monnet <qmo@...nel.org>,
 Changbin Du <changbin.du@...wei.com>, Fangrui Song <maskray@...gle.com>,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
 Guilherme Amadio <amadio@...too.org>
Subject: Re: [PATCH v2 3/6] perf: build: Only link libebl.a for old libdw


On 6/22/24 00:40, Namhyung Kim wrote:
> 
> On Mon, Jun 10, 2024 at 10:54:30AM +0100, Leo Yan wrote:
>> Since libdw version 0.177, elfutils has merged libebl.a into libdw (see
>> the commit "libebl: Don't install libebl.a, libebl.h and remove backends
>> from spec." in the elfutils repository).
>>
>> As a result, libebl.a does not exist on Debian Bullseye and newer
>> releases, causing static perf builds to fail on these distributions.
> 
> What about libebl.so?  I'm curious why it's ok with dynamic build and
> causing a problem with static builds.

For the new Debian / Ubuntu distros, libebl has been merged in libdw so
merged into libdw, so libebl.so doesn't exist.

'-lebl' is only included only for static building (see below code piece,
it detects '-static' in ${LDFLAGS}).  This is why dynamic build has no
issue.

>> This commit checks the libdw version and only links libebl.a if it
>> detects that the libdw version is older than 0.177.
> 
> Have you tested on the older versions too?

IIRC, I did test on the Debian buster (which contains the libdw version
is 0.176).

>> Signed-off-by: Leo Yan <leo.yan@....com>
>> ---
>>   tools/build/feature/Makefile | 12 +++++++++++-
>>   tools/perf/Makefile.config   | 12 +++++++++++-
>>   2 files changed, 22 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
>> index 084f803093c3..b23b3e8ad5e4 100644
>> --- a/tools/build/feature/Makefile
>> +++ b/tools/build/feature/Makefile
>> @@ -171,7 +171,17 @@ $(OUTPUT)test-libopencsd.bin:
>>
>>   DWARFLIBS := -ldw
>>   ifeq ($(findstring -static,${LDFLAGS}),-static)
>> -DWARFLIBS += -lelf -lebl -lz -llzma -lbz2
>> +  DWARFLIBS += -lelf -lz -llzma -lbz2
>> +
>> +  LIBDW_VERSION := $(shell $(PKG_CONFIG) --modversion libdw)
>> +  LIBDW_VERSION_1 := $(word 1, $(subst ., ,$(LIBDW_VERSION)))
>> +  LIBDW_VERSION_2 := $(word 2, $(subst ., ,$(LIBDW_VERSION)))
>> +
>> +  # Elfutils merged libebl.a into libdw.a starting from version 0.177,
>> +  # Link libebl.a only if libdw is older than this version.
>> +  ifeq ($(shell test $(LIBDW_VERSION_2) -lt 177; echo $$?),0)
>> +    DWARFLIBS += -lebl
> 
> I'm not sure if it's ok to change the order as libebl might depend on
> later libraries like libz.

I confirmed that this change works on Debian Buster (Debian 10) and
Bookworm (Debian 12).

Thanks,
Leo