linux-kernel - Re: [PATCH] mm: remove partial comments of kswapd_shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 11:15:22 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "yongfa.hu" <hushange@....com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: remove partial comments of kswapd_shrink_node head

On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" <hushange@....com> wrote:

> when function kswapd_shrink_node return, it will not check the condition
> mentioned in the removed comments: "if the lack of progress was
> due to pages under writeback", so remove it.

Is this correct?  shrink_folio_list() can skip under-writeback pages?


> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order,
>   * zone that is currently unbalanced.
>   *
>   * Returns true if kswapd scanned at least the requested number of pages to
> - * reclaim or if the lack of progress was due to pages under writeback.
> - * This is used to determine if the scanning priority needs to be raised.
> + * reclaim. This is used to determine if the scanning priority needs to be raised.
>   */
>  static bool kswapd_shrink_node(pg_data_t *pgdat,
>  			       struct scan_control *sc)
> -- 
> 2.17.1