linux-kernel - Re: [PATCH] dm cache metadata: remove unused struct 'thunk'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c08ab47c-944c-7393-d403-e4435cb283dc@redhat.com>
Date: Tue, 25 Jun 2024 14:37:24 -0400
From: Matthew Sakai <msakai@...hat.com>
To: linux@...blig.org, agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com
Cc: dm-devel@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dm cache metadata: remove unused struct 'thunk'


On 5/23/24 17:05, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
Reviewed-by: Matthew Sakai <msakai@...hat.com>

> ---
>   drivers/md/dm-cache-metadata.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
>   	return r;
>   }
>   
> -struct thunk {
> -	load_mapping_fn fn;
> -	void *context;
> -
> -	struct dm_cache_metadata *cmd;
> -	bool respect_dirty_flags;
> -	bool hints_valid;
> -};
> -
>   static bool policy_unchanged(struct dm_cache_metadata *cmd,
>   			     struct dm_cache_policy *policy)
>   {