linux-kernel - Re: [PATCH] cpufreq: intel_pstate: Replace boot_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 21:01:49 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc: rafael@...nel.org, viresh.kumar@...aro.org, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: intel_pstate: Replace boot_cpu_has()

On Mon, Jun 24, 2024 at 6:27 PM Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
>
> Replace boot_cpu_has() with cpu_feature_enabled().
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---
> This is based on comment from Borislov for the change to suppot HWP
> highest interrupt.
>
>  drivers/cpufreq/intel_pstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index d53b99bab687..4ee244f59f54 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1635,7 +1635,7 @@ void notify_hwp_interrupt(void)
>         u64 value, status_mask;
>         unsigned long flags;
>
> -       if (!hwp_active || !boot_cpu_has(X86_FEATURE_HWP_NOTIFY))
> +       if (!hwp_active || !cpu_feature_enabled(X86_FEATURE_HWP_NOTIFY))
>                 return;
>
>         status_mask = HWP_GUARANTEED_PERF_CHANGE_STATUS;
> @@ -1667,7 +1667,7 @@ static void intel_pstate_disable_hwp_interrupt(struct cpudata *cpudata)
>  {
>         bool cancel_work;
>
> -       if (!boot_cpu_has(X86_FEATURE_HWP_NOTIFY))
> +       if (!cpu_feature_enabled(X86_FEATURE_HWP_NOTIFY))
>                 return;
>
>         /* wrmsrl_on_cpu has to be outside spinlock as this can result in IPC */
> --

Applied as 6.11 material, thanks!