linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add simple-mfd compatible to SerDes control nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 23:53:05 +0200
From: Jan Kiszka <jan.kiszka@...mens.com>
To: Andrew Davis <afd@...com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Tony Lindgren <tony@...mide.com>,
 Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add simple-mfd compatible to
 SerDes control nodes

On 25.06.24 18:45, Andrew Davis wrote:
> The SerDes control nodes contain both a clock and clock mux, this is
> a simple MFD. Add this to the compatible string list.
> 
> Reported-by: Jan Kiszka <jan.kiszka@...mens.com>
> Fixes: da795dc4f2a0 ("arm64: dts: ti: k3-am65: Move SerDes mux nodes under the control node")
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 1af3dedde1f67..06ed74197f893 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -478,7 +478,7 @@ scm_conf: scm-conf@...000 {
>  		ranges = <0x0 0x0 0x00100000 0x1c000>;
>  
>  		serdes0_clk: clock@...0 {
> -			compatible = "ti,am654-serdes-ctrl", "syscon";
> +			compatible = "ti,am654-serdes-ctrl", "syscon", "simple-mfd";
>  			reg = <0x4080 0x4>;
>  
>  			serdes0_mux: mux-controller {
> @@ -489,7 +489,7 @@ serdes0_mux: mux-controller {
>  		};
>  
>  		serdes1_clk: clock@...0 {
> -			compatible = "ti,am654-serdes-ctrl", "syscon";
> +			compatible = "ti,am654-serdes-ctrl", "syscon", "simple-mfd";
>  			reg = <0x4090 0x4>;
>  
>  			serdes1_mux: mux-controller {

Tested-by: Jan Kiszka <jan.kiszka@...mens.com>

Was briefly nervous as the fix initially no longer worked. But I had
switched devices in the meantime, ending up on a SR1.0 variant. And for
that, we are still missing a PCI errata workaround from your SDK in
mainline...

Jan

-- 
Siemens AG, Technology
Linux Expert Center