linux-kernel - Re: [PATCH] xfs: make xfs_log_iovec independent from xfs_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 05:56:06 +0800
From: kernel test robot <lkp@...el.com>
To: alexjlzheng@...il.com, chandan.babu@...cle.com, djwong@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, alexjlzheng@...cent.com
Subject: Re: [PATCH] xfs: make xfs_log_iovec independent from xfs_log_vec and
 release it early

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on linus/master v6.10-rc5 next-20240625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/alexjlzheng-gmail-com/xfs-make-xfs_log_iovec-independent-from-xfs_log_vec-and-release-it-early/20240625-192710
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
patch link:    https://lore.kernel.org/r/20240623123119.3562031-1-alexjlzheng%40tencent.com
patch subject: [PATCH] xfs: make xfs_log_iovec independent from xfs_log_vec and release it early
config: i386-buildonly-randconfig-004-20240626 (https://download.01.org/0day-ci/archive/20240626/202406260523.tGxY7QOx-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240626/202406260523.tGxY7QOx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406260523.tGxY7QOx-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from fs/xfs/libxfs/xfs_da_btree.c:24:
   fs/xfs/xfs_log.h: In function 'xlog_finish_iovec':
>> fs/xfs/xfs_log.h:46:34: warning: unused variable 'lvec' [-Wunused-variable]
      46 |         struct xfs_log_iovec    *lvec = lv->lv_iovecp;
         |                                  ^~~~


vim +/lvec +46 fs/xfs/xfs_log.h

    38	
    39	void *xlog_prepare_iovec(struct xfs_log_vec *lv, struct xfs_log_iovec **vecp,
    40			uint type);
    41	
    42	static inline void
    43	xlog_finish_iovec(struct xfs_log_vec *lv, struct xfs_log_iovec *vec,
    44			int data_len)
    45	{
  > 46		struct xfs_log_iovec	*lvec = lv->lv_iovecp;
    47		struct xlog_op_header	*oph = vec->i_addr;
    48		int			len;
    49	
    50		/*
    51		 * Always round up the length to the correct alignment so callers don't
    52		 * need to know anything about this log vec layout requirement. This
    53		 * means we have to zero the area the data to be written does not cover.
    54		 * This is complicated by fact the payload region is offset into the
    55		 * logvec region by the opheader that tracks the payload.
    56		 */
    57		len = xlog_calc_iovec_len(data_len);
    58		if (len - data_len != 0) {
    59			char	*buf = vec->i_addr + sizeof(struct xlog_op_header);
    60	
    61			memset(buf + data_len, 0, len - data_len);
    62		}
    63	
    64		/*
    65		 * The opheader tracks aligned payload length, whilst the logvec tracks
    66		 * the overall region length.
    67		 */
    68		oph->oh_len = cpu_to_be32(len);
    69	
    70		len += sizeof(struct xlog_op_header);
    71		lv->lv_buf_len += len;
    72		lv->lv_bytes += len;
    73		vec->i_len = len;
    74	
    75		/* Catch buffer overruns */
    76		ASSERT((void *)lv->lv_buf + lv->lv_bytes <= (void *)lvec + lv->lv_size);
    77	}
    78	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki