[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ce838686-8309-4301-a05b-28f72357495f@intel.com>
Date: Tue, 25 Jun 2024 16:28:23 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
<Dave.Martin@....com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
<patches@...ts.linux.dev>
Subject: Re: [PATCH v21 08/18] x86/resctrl: Prepare for new Sub-NUMA Cluster
(SNC) monitor files
Hi Tony,
On 6/21/24 3:38 PM, Tony Luck wrote:
> When SNC is enabled monitoring data is collected at the SNC node
> granularity, but must be reported at L3-cache granularity for
> backwards compatibility in addition to reporting at the node
> level.
>
> Add a "ci" field to the rdt_mon_domain structure to save the
> cache information about the enclosing L3 cache for the domain.
> This provides:
>
> 1) The cache id which is needed to compose the name of the legacy
> monitoring directory, and to determine which domains should be
> summed to provide L3-scoped data.
>
> 2) The shared_cpu_map which is needed to determine which CPUs can
> be used to read the RMID counters with the MSR interface.
>
> This is the first step to an eventual goal of monitor reporting files
> like this (for a system with two SNC nodes per L3):
>
> $ cd /sys/fs/resctrl/mon_data
> $ tree mon_L3_00
> mon_L3_00 <- 00 here is L3 cache id
> ├── llc_occupancy \ These files provide legacy support
> ├── mbm_local_bytes > for non-SNC aware monitor apps
> ├── mbm_total_bytes / that expect data at L3 cache level
> ├── mon_sub_L3_00 <- 00 here is SNC node id
> │ ├── llc_occupancy \ These files are finer grained
> │ ├── mbm_local_bytes > data from each SNC node
> │ └── mbm_total_bytes /
> └── mon_sub_L3_01
> ├── llc_occupancy \
> ├── mbm_local_bytes > As above, but for node 1.
> └── mbm_total_bytes /
>
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---
Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
Reinette
Powered by blists - more mailing lists