linux-kernel - Re: [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 13:00:03 +0800
From: Tianyang Zhang <zhangtianyang@...ngson.cn>
To: Thomas Gleixner <tglx@...utronix.de>, kernel test robot <lkp@...el.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 x86@...nel.org, Jianmin Lv <lvjianmin@...ngson.cn>,
 Liupu Wang <wangliupu@...ngson.cn>
Subject: Re: [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17:
 error: implicit declaration of function 'loongson_send_ipi_single'

Hi, Thomas

在 2024/6/24 下午9:45, Thomas Gleixner 写道:
> On Mon, Jun 24 2024 at 05:06, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
>> head:   c9d269469d2b9a06559cdc84d12dd3fb4d552581
>> commit: 760d7e719499d64beea62bfcf53938fb233bb6e7 [39/46] Loongarch: Support loongarch avec
>> config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/config)
>> compiler: loongarch64-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202406240451.ygBFNyJ3-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>>     drivers/irqchip/irq-loongarch-avec.c: In function 'loongarch_avec_sync':
>>>> drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' [-Werror=implicit-function-declaration]
>>        82 |                 loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
>>           |                 ^~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/irqchip/irq-loongarch-avec.c:82:59: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
>>        82 |                 loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
>>           |                                                           ^~~~~~~~~~~~~~
>>     drivers/irqchip/irq-loongarch-avec.c:82:59: note: each undeclared identifier is reported only once for each function it appears in
>>     drivers/irqchip/irq-loongarch-avec.c: In function 'complete_irq_moving':
>>     drivers/irqchip/irq-loongarch-avec.c:173:55: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
>>       173 |                         loongson_send_ipi_single(cpu, SMP_CLEAR_VECT);
>>           |                                                       ^~~~~~~~~~~~~~
> So this code was never built with CONFIG_SMP=n.
>
> Can the loongson folks please send me a delta patch ASAP, otherwise I'm
> going to revert it.
>
> Thanks,
>
>          tglx

We have also noticed this issue and found that the patch has other 
issues that may cause it to fail to start on a certain model of machine.
If possible, please reverse this patch and we will resend a V2 version 
patch as soon as possible based on this patch

Thanks you

             Tianyang