linux-kernel - Re: [PATCH v7 2/3] dt-bindings: iio: proximity: Add TYHX HX9023S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d77a4777-d282-4004-895a-7809abf68130@kernel.org>
Date: Tue, 25 Jun 2024 07:48:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yasin Lee <yasin.lee.x@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, yasin.lee.x@...look.com
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, Conor Dooley <conor@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v7 2/3] dt-bindings: iio: proximity: Add TYHX HX9023S

On 25/06/2024 04:15, Yasin Lee wrote:
> A capacitive proximity sensor
> 
> Acked-by: Conor Dooley <conor@...nel.org>
> Acked-by: Jonathan Cameron <jic23@...nel.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

What? How did this happen? Where - provide lore links to prove it?

NAK

> Reported-by： "Rob Herring (Arm)" <robh@...nel.org>

No, drop.

> Signed-off-by: Yasin Lee <yasin.lee.x@...il.com>


> +
> +patternProperties:
> +  "^channel@[0-4]$":
> +    $ref: /schemas/iio/adc/adc.yaml
> +    type: object
> +
> +    properties:
> +      reg:
> +        minimum: 0
> +        maximum: 4
> +        description: The channel number.
> +
> +      single-channel: true
> +
> +      diff-channels: true
> +
> +    oneOf:
> +      - required:
> +          - single-channel
> +      - required:
> +          - diff-channels
> +
> +    required:
> +      - reg

... and now you should see that you duplicated adc.yaml. This should be
just:

+patternProperties:
+  "^channel@[0-4]$":
+    $ref: /schemas/iio/adc/adc.yaml
+    type: object
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        minimum: 0
+        maximum: 4
+        description: The channel number.



Best regards,
Krzysztof