linux-kernel - Re: [PATCH v2 2/5] x86/mce: Fixup APIC ID search for x86 CPER decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bk3p7by0.ffs@tglx>
Date: Tue, 25 Jun 2024 08:50:47 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Yazen Ghannam <yazen.ghannam@....com>, linux-edac@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, tony.luck@...el.com, x86@...nel.org,
 avadhut.naik@....com, john.allen@....com, Yazen Ghannam
 <yazen.ghannam@....com>
Subject: Re: [PATCH v2 2/5] x86/mce: Fixup APIC ID search for x86 CPER decoding

On Mon, Jun 24 2024 at 16:20, Yazen Ghannam wrote:
>  	/*
>  	 * The starting address of the register array extracted from BERT must
>  	 * match with the first expected register in the register layout of
> @@ -99,16 +103,8 @@ int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 lapic_id)
>  
>  	mce_setup(&m);
>  
> -	m.extcpu = -1;
> -	m.socketid = -1;
> -
> -	for_each_possible_cpu(cpu) {
> -		if (cpu_data(cpu).topo.initial_apicid == lapic_id) {
> -			m.extcpu = cpu;
> -			m.socketid = cpu_data(m.extcpu).topo.pkg_id;
> -			break;
> -		}
> -	}
> +	m.extcpu   = cpu;
> +	m.socketid = cpu_data(cpu).topo.pkg_id;

topology_physical_package_id() ?

Thanks,

        tglx