linux-kernel - Re: [PATCH] Bluetooth: qca: don't disable power management for QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 09:57:11 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] Bluetooth: qca: don't disable power management for QCA6390

On Tue, 25 Jun 2024 at 09:50, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> On Mon, 24 Jun 2024 23:19:55 +0200, Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> said:
> > On Mon, 24 Jun 2024 at 23:47, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >>
> >> On Mon, Jun 24, 2024 at 10:17 PM Dmitry Baryshkov
> >> <dmitry.baryshkov@...aro.org> wrote:
> >> >
> >> > On Mon, 24 Jun 2024 at 22:45, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >> > >
> >> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >> > >
> >> > > We unnecessarily fallthrough the case for QCA6390 when initializing the
> >> > > device and hit the condition where - due to the lack of the enable-gpio
> >> > > - we disable power management despite using the power sequencer. We don't
> >> > > need to look for clocks on this model so it makes more sense to just
> >> > > register the hci device and break the switch.
> >> > >
> >> > > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> >> > > Fixes: 4029dba6b6f1 ("Bluetooth: qca: use the power sequencer for QCA6390")
> >> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >> >
> >> > Is this going to break the QCA6390 as present on M.2 / PCIe cards? Or
> >> > the older DT which didn't have pwrseq entries?
> >> >
> >>
> >> Neither of these has clocks that need to be driven by linux. The only
> >> user of QCA6390 Bluetooth in mainline is RB5. Bindings didn't exist
> >> before so no commitment was ever made.
> >
> > This might make some laptop users unhappy. But anyway, restarting the
> > hci0 now gives:
> >
> > [   24.387344] Bluetooth: hci0: setting up ROME/QCA6390
> > [   24.387439] qcom_geni_serial 998000.serial: serial engine reports 0
> > RX bytes in!
> > [   24.554349] qcom_geni_serial 998000.serial: serial engine reports 0
> > RX bytes in!
> > [   24.562056] arm-smmu 15000000.iommu: Unhandled context fault:
> > fsr=0x402, iova=0xfffd1080, fsynr=0x750013, cbfrsynra=0x5a3, cb=3
> > [   26.914225] Bluetooth: hci0: command 0xfc00 tx timeout
> > [   35.042619] Bluetooth: hci0: Reading QCA version information failed (-110)
> > [   35.049721] Bluetooth: hci0: Retry BT power ON:0
> > [   37.539492] Bluetooth: hci0: command 0xfc00 tx timeout
> > [   45.539519] Bluetooth: hci0: Reading QCA version information failed (-110)
> > [   45.546667] Bluetooth: hci0: Retry BT power ON:1
> > [   48.035863] Bluetooth: hci0: command 0xfc00 tx timeout
> > [   56.034783] Bluetooth: hci0: Reading QCA version information failed (-110)
> > [   56.041901] Bluetooth: hci0: Retry BT power ON:2
> > [   58.532174] Bluetooth: hci0: command 0xfc00 tx timeout
> > [   66.531928] Bluetooth: hci0: Reading QCA version information failed (-110)
> >
> >
>
> How do you reproduce it because it works fine for me:

Hmm, most likely I had a dirty kernel version somewhere. With the
current linux-next it works for me too.

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Tested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> # RB5

Thank you!

-- 
With best wishes
Dmitry