linux-kernel - Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734p179c2.ffs@tglx>
Date: Tue, 25 Jun 2024 09:47:09 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Marc Zyngier <maz@...nel.org>
Cc: Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-pci@...r.kernel.org, anna-maria@...utronix.de, shawnguo@...nel.org,
 s.hauer@...gutronix.de, festevam@...il.com, bhelgaas@...gle.com,
 rdunlap@...radead.org, vidyas@...dia.com, ilpo.jarvinen@...ux.intel.com,
 apatel@...tanamicro.com, kevin.tian@...el.com, nipun.gupta@....com,
 den@...inux.co.jp, andrew@...n.ch, gregory.clement@...tlin.com,
 sebastian.hesselbarth@...il.com, gregkh@...uxfoundation.org,
 rafael@...nel.org, alex.williamson@...hat.com, will@...nel.org,
 lorenzo.pieralisi@....com, jgg@...lanox.com, ammarfaizi2@...weeb.org,
 robin.murphy@....com, lpieralisi@...nel.org, nm@...com, kristo@...nel.org,
 vkoul@...nel.org, okaya@...nel.org, agross@...nel.org,
 andersson@...nel.org, mark.rutland@....com,
 shameerali.kolothum.thodi@...wei.com, yuzenghui@...wei.com
Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI
 mechanics

On Tue, Jun 25 2024 at 08:37, Marc Zyngier wrote:
> On Mon, 17 Jun 2024 15:15:44 +0100,
> Thomas Gleixner <tglx@...utronix.de> wrote:
>> just install their special MSI write callback. I don't see any of those
>> setting up LEVEL triggered MSIs.
>> 
>> But then I'm might be missing something. If so can you point me please
>> to the usage instance which actually uses level signaled MSI?
>
> Good question. I'm pretty sure we had *something* at some point that
> used it, or that was planning on using it. I even vividly remember who
> was asking for this.
>
> But either that never really made it upstream, or they decided to move
> away from the kernel setting the MSI up and relied on firmware for
> that (which is fine as long as the device isn't behind an IOMMU).
>
> In the end, it begs the question of what we want to do with this
> feature.  I don't think it is a big deal to keep it around, but maybe
> we should plan for it to be retired. That's independent of this
> series, IMO.

I reworked the conversion so that it keeps it alive. We can remove it
later nevertheless :)

Thanks,

        tglx