linux-kernel - Re: [PATCH v2] drm/ttm/tests: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1bea3fc8-1c29-4951-b077-d442257c93e5@amd.com>
Date: Tue, 25 Jun 2024 10:00:24 +0200
From: Christian König <christian.koenig@....com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, Huang Rui <ray.huang@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

Am 25.06.24 um 03:24 schrieb Jeff Johnson:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_device_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_pool_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_resource_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_tt_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_mock_manager.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

Acked and pushed to drm-misc-next.

Thanks,
Christian.

> ---
> Changes in v2:
> - Rebased on top of linux-next/master to resolve conflict with commit
>    "drm/ttm/tests: Correct modules' licenses" as well as add descriptions
>    for two new modules recently added.
> - Link to v1: https://lore.kernel.org/r/20240609-md-drivers-gpu-drm-ttm-tests-v1-1-d94123d95b4c@quicinc.com
> ---
>   drivers/gpu/drm/ttm/tests/ttm_bo_test.c          | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_device_test.c      | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c    | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_mock_manager.c     | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_pool_test.c        | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_resource_test.c    | 1 +
>   drivers/gpu/drm/ttm/tests/ttm_tt_test.c          | 1 +
>   8 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> index 407c31b21872..d1b32303d051 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> @@ -633,4 +633,5 @@ static struct kunit_suite ttm_bo_test_suite = {
>   
>   kunit_test_suites(&ttm_bo_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_bo APIs");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> index bc8281c03420..1adf18481ea0 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c
> @@ -1221,4 +1221,5 @@ static struct kunit_suite ttm_bo_validate_test_suite = {
>   
>   kunit_test_suites(&ttm_bo_validate_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_bo APIs");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> index 0f235a834ede..1621903818e5 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> @@ -209,4 +209,5 @@ static struct kunit_suite ttm_device_test_suite = {
>   
>   kunit_test_suites(&ttm_device_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_device APIs");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> index 70f40814b26a..b91c13f46225 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> @@ -301,4 +301,5 @@ void ttm_test_devices_fini(struct kunit *test)
>   }
>   EXPORT_SYMBOL_GPL(ttm_test_devices_fini);
>   
> +MODULE_DESCRIPTION("TTM KUnit test helper functions");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c b/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> index 7f34fecd3fef..f6d1c8a2845d 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_mock_manager.c
> @@ -230,4 +230,5 @@ void ttm_bad_manager_fini(struct ttm_device *bdev, uint32_t mem_type)
>   }
>   EXPORT_SYMBOL_GPL(ttm_bad_manager_fini);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm with mock resource managers");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> index 5d4dc5b1c6d7..8ade53371f72 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_pool_test.c
> @@ -433,4 +433,5 @@ static struct kunit_suite ttm_pool_test_suite = {
>   
>   kunit_test_suites(&ttm_pool_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_pool APIs");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_resource_test.c b/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> index 77be0942ab62..9c2f13e53162 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_resource_test.c
> @@ -332,4 +332,5 @@ static struct kunit_suite ttm_resource_test_suite = {
>   
>   kunit_test_suites(&ttm_resource_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_resource and ttm_sys_man APIs");
>   MODULE_LICENSE("GPL and additional rights");
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_tt_test.c b/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> index a8c76dbd6913..61ec6f580b62 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_tt_test.c
> @@ -398,4 +398,5 @@ static struct kunit_suite ttm_tt_test_suite = {
>   
>   kunit_test_suites(&ttm_tt_test_suite);
>   
> +MODULE_DESCRIPTION("KUnit tests for ttm_tt APIs");
>   MODULE_LICENSE("GPL and additional rights");
>
> ---
> base-commit: 62c97045b8f720c2eac807a5f38e26c9ed512371
> change-id: 20240609-md-drivers-gpu-drm-ttm-tests-f7b63f46eb3c
>