linux-kernel - [PATCH v4 0/5] Fix MEI command timeout issue following warm reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240625081047.4178494-1-wentong.wu@intel.com>
Date: Tue, 25 Jun 2024 16:10:42 +0800
From: Wentong Wu <wentong.wu@...el.com>
To: sakari.ailus@...ux.intel.com,
	tomas.winkler@...el.com,
	gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org,
	Wentong Wu <wentong.wu@...el.com>
Subject: [PATCH v4 0/5] Fix MEI command timeout issue following warm reboot

While enabling the IVSC on certain recent commercial products, the chipset
may occasionally enter an unknown state following a warm reboot. This issue
can cause the firmware to fail in responding to the MEI command from the
host, despite the firmware being re-downloaded. To resolve this, the current
patch set incorporates reset logic during system shutdown to ensure that the
IVSC chipset remains in a valid state after a warm reboot.

Furthermore, after the firmware download is complete, the firmware requires
some time to become operational. To enhance this, additional sleep time has
been introduced before the initial read operation to prevent a confusing
timeout error in vsc_tp_xfer().

Additionally, this patch set includes several enhancements as well:
1) utilizing the appropriate byte order swap function for data received
from the ROM;
2) correcting a spelling error in a comment;
3) constructing the SPI transfer command as per the specific request.

---
v3 -> v4:
 - remove `Fixes:` in the commit message of comment spelling fix
 - re-write the commit message of change "Enhance SPI transfer of IVSC ROM"
to easy to understand

v2 -> v3:
 - switch code from `ibuf ? tp->rx_buf : ibuf` to `ibuf ? tp->rx_buf : NULL`

v1 -> v2:
 - remove cc spelling fix to stable
 - remove the reset toggling enhancement

Wentong Wu (5):
  mei: vsc: Enhance IVSC chipset stability during warm reboot
  mei: vsc: Prevent timeout error with added delay post-firmware
    download
  mei: vsc: Utilize the appropriate byte order swap function
  mei: vsc: Enhance SPI transfer of IVSC ROM
  mei: vsc: Fix spelling error

 drivers/misc/mei/platform-vsc.c  |  4 ++--
 drivers/misc/mei/vsc-fw-loader.c |  2 +-
 drivers/misc/mei/vsc-tp.c        | 18 ++++++++++++++++--
 3 files changed, 19 insertions(+), 5 deletions(-)

-- 
2.34.1