linux-kernel - Re: [PATCH V4 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171930418133.2076741.5571224940926459410.robh@kernel.org>
Date: Tue, 25 Jun 2024 02:29:41 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Devi Priya <quic_devipriy@...cinc.com>
Cc: dmitry.baryshkov@...aro.org, netdev@...r.kernel.org, arnd@...db.de, 
 krzk+dt@...nel.org, nfraprado@...labora.com, m.szyprowski@...sung.com, 
 neil.armstrong@...aro.org, konrad.dybcio@...aro.org, 
 linux-arm-msm@...r.kernel.org, conor+dt@...nel.org, sboyd@...nel.org, 
 linux-arm-kernel@...ts.infradead.org, geert+renesas@...der.be, 
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org, will@...nel.org, 
 andersson@...nel.org, mturquette@...libre.com, u-kumar1@...com, 
 catalin.marinas@....com, richardcochran@...il.com, 
 linux-kernel@...r.kernel.org, p.zabel@...gutronix.de
Subject: Re: [PATCH V4 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and
 reset definitions


On Tue, 25 Jun 2024 12:35:33 +0530, Devi Priya wrote:
> Add NSSCC clock and reset definitions for ipq9574.
> 
> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  Changes in V4:
> 	- Added GCC_NSSCC_CLK source to the clocks
> 	- Added support for interconnects and interconnect-names as the NoC
> 	  clocks are being enabled via interconnect.
> 
>  .../bindings/clock/qcom,ipq9574-nsscc.yaml    |  75 +++++++++
>  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
>  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
>  3 files changed, 361 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
>  create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240625070536.3043630-5-quic_devipriy@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.