Message-ID: <4647181b-e5a0-4f6e-9aba-1bcde763d678@collabora.com>
Date: Tue, 25 Jun 2024 10:49:16 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Linux regressions mailing list <regressions@...ts.linux.dev>,
 Paolo Abeni <pabeni@...hat.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Daniel Golle <daniel@...rotopia.org>, frank-w@...lic-files.de,
 Frank Wunderlich <linux@...web.de>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64

Il 25/06/24 10:17, Arınç ÜNAL ha scritto:
> On 25/06/2024 09.57, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 25.06.24 08:17, Arınç ÜNAL wrote:
>>> On 25/06/2024 08.56, Linux regression tracking (Thorsten Leemhuis) wrote:
>>>> On 17.06.24 13:08, Arınç ÜNAL wrote:
>>>>> On 17/06/2024 11:33, Linux regression tracking (Thorsten Leemhuis)
>>>>> wrote:
>>>>> [...]
>>>>> I've submitted a patch series that fixes the regression. Angelo argued
>>>>> against the way the regression is fixed. I've very clearly argued
>>>>> back why
>>>>> I find Angelo's approach wrong. There's been no response back. I don't
>>>>> understand why reverting the patch is the likely outcome
>>>>
>>>> Long story short: because that how things like that are handled in the
>>>> Linux kernel project, as Linus wants it like that. See some of the
>>>> quotes from https://docs.kernel.org/process/handling-regressions.html
>>>> for details.
>>>>
>>>>> whilst the
>>>>> standing argument points towards applying the said patch series. If a
>>>>> revert happens before this discussion with Angelo finalises, this
>>>>> will set
>>>>> a precedent that will tell maintainers that they can have their way
>>>>> by just
>>>>> not replying to the ongoing discussions.
>>>>>
>>>>> That said, the decision of resolving the regression by either
>>>>> reverting the
>>>>> patch or applying the patch series shall not depend on whether or not
>>>>> Angelo is pleased but rather there're no counter-arguments left on the
>>>>> points brought, meaning the decision shall be made depending on the
>>>>> argument that stands.
>>>>>
>>>>> Therefore, I suggest that unless Angelo responds back with a
>>>>> counter-argument in the window of a week or two, as you've described, my
>>>>> patch series shall be applied.
>>>>
>>>> It looks more and more like we are stuck here (or was there progress and
>>>> I just missed it?) while the 6.10 final is slowly getting closer. Hence:
>>>
>>> There hasn't been progress at all. I believe I have clearly described the
>>> way out of this issue.
>>>
>>>> AngeloGioacchino, should we ask the net maintainers to revert
>>>> 868ff5f4944aa9 ("net: dsa: mt7530-mdio: read PHY address of switch from
>>>> device tree") for now to resolve this regression? Reminder, there is
>>>> nothing wrong with that commit per se afaik, it just exposes a problem
>>>> that needs to be fixed first before it can be reapplied.
>>>
>>> Are you suggesting the patch shall be reverted first, then the DT patch
>>> applied, then the reverted patch applied back?
>>
>> Yeah.
>>

Sorry, I've lost your reply in the long stack of emails that I get every day.

I'm not suggesting to revert the patch, but to fix it such that it does not
break devices using old devicetrees, as it was the case before.

Even though, in a way, when you update the kernel, you do also update the
devicetrees with it just because it's almost effortless to do so, doing that
is not mandatory.

...and that's why the driver, which was - in a way - faulty before, getting
the switch to work even though the devicetree node was wrong, must still be
compatible.

I do want to apply the devicetree fix, but I also do *not* want to see *driver*
changes that go against the backward compatibility rule of devicetree when this
is not strictly necessary (when it is - it's okay to make an exception)...

...and this is not one of the cases in which it's strictly necessary.

>>> If only one of the first two
>>> steps were done, it would fix the regression so I don't understand why go
>>> through this tedious process when we can quite simply apply the DT patch to
>>> resolve the regression.
>>
>> Which DT patch do you mean here? Your series or the one from Frank at
>> the start of the thread (the one you seems to be unhappy about iirc, but
>> I might be wrong there)?
> 
> My series, as arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts needs to be
> addressed too to resolve the regression.
> 
>>
>> Anyway, to answer the statement: because the maintainers that would have
>> to accept the DT patch to resolve the problem apparently are not happy
>> with it -- and nobody seems to be working on providing patches that make
>> them happy which are also acceptable at this point of the devel cycle;
>> so as it looks like currently to prevent the regression from entering
>> 6.10 reverting the net change is the only option left.
> 
> I've already made my case regarding the situation with the DT patch. I
> can't provide new patches because Angelo did not acknowledge my points yet.
> I maintain the net driver and I too won't be happy with a revert on the
> driver.
> 

And again, I wouldn't be happy to see a revert either; just fix it so that the
old devicetree still works with the driver code.

Regards,
Angelo

Powered by blists - more mailing lists