linux-kernel - Re: [PATCH] Bluetooth: qca: don't disable power management for QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqXEAL-EzGJqJXbJv4z8w4M7Fr61mH_dcHqWgiPZHbNNg@mail.gmail.com>
Date: Tue, 25 Jun 2024 12:02:33 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Marcel Holtmann <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, 
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] Bluetooth: qca: don't disable power management for QCA6390

On Tue, 25 Jun 2024 at 12:01, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> On Tue, Jun 25, 2024 at 10:55 AM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
> >
> > On Tue, 25 Jun 2024 at 11:50, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > On Tue, Jun 25, 2024 at 9:47 AM Dmitry Baryshkov
> > > <dmitry.baryshkov@...aro.org> wrote:
> > > >
> > > > On Tue, 25 Jun 2024 at 10:46, Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > > > >
> > > > > On Mon, Jun 24, 2024 at 11:20 PM Dmitry Baryshkov
> > > > > <dmitry.baryshkov@...aro.org> wrote:
> > > > > >
> > > > > > >
> > > > > > > Neither of these has clocks that need to be driven by linux. The only
> > > > > > > user of QCA6390 Bluetooth in mainline is RB5. Bindings didn't exist
> > > > > > > before so no commitment was ever made.
> > > > > >
> > > > > > This might make some laptop users unhappy.
> > > > >
> > > > > Like I said: without upstreamed DT bindings, we have never made any
> > > > > commitment about the device properties. I doubt anyone will complain
> > > > > though, I haven't seen any DT with QCA6390 with clock properties yet.
> > > > > I wouldn't stress it for now.
> > > >
> > > > I was thinking about x86 laptops / M.2 cards. I'll see if I can locate one.
> > > >
> > >
> > > I don't get it, how could they ever get the clocks property without it
> > > being defined in firmware?
> >
> > The clock and bt_en are optional.
> >
>
> But you're worrying that the lack of this optional clock for QCA6390
> will break it on some M.2 card? That cannot happen, can it? If it's on
> an M.2 card then it would never be described in ACPI.
> clk_get_optional() will always return NULL.

Ack, thank you for the explanation.

-- 
With best wishes
Dmitry