linux-kernel - Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 12:53:00 +0300
From: Dmitry Rokosov <ddrokosov@...utedevices.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
CC: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	<devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-amlogic@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name

Hello Neil and Krzysztof,

Before posting any commit I've running dt_binding_check and dtbs_check.
Which target should highlight the errors like mentioned in this fix?
Please advise what I'm doing wrong.

My commands:

$ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml
$ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml

On Mon, Jun 24, 2024 at 11:45:51AM +0200, Neil Armstrong wrote:
> On 24/06/2024 11:28, Krzysztof Kozlowski wrote:
> > On 24/06/2024 10:59, Neil Armstrong wrote:
> > > Fixes the following:
> > > thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
> > >          from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
> > > 
> > > Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones")
> > > Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> > > ---
> > >   arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > index 6883471a93b4..0d92f5253b64 100644
> > > --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts
> > > @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 {
> > >   	};
> > >   	thermal-zones {
> > > -		soc_thermal: soc_thermal {
> > > +		soc_thermal: soc-thermal {
> > 
> > I was fixing all underscores... but then mentioned above commit
> > re-introduced them.
> 
> Sorry about that, I'm removing all dtbs check errors, so I'll be able to spot
> this before merging anything now !
> 
> > 
> > Some fixes need to be done more than once to stick. :)
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> >
> > Best regards,
> > Krzysztof
> > 
> 
> Thanks,
> Neil

-- 
Thank you,
Dmitry