linux-kernel - Re: [PATCH 00/15] ethernet: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac1789693e62aa47b527294fd402718306e43afd.camel@redhat.com>
Date: Tue, 25 Jun 2024 12:24:11 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Allen Pais <allen.lkml@...il.com>, kuba@...nel.org, Matthias Brugger
	 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	 <angelogioacchino.delregno@...labora.com>
Cc: jes@...ined-monkey.org, davem@...emloft.net, edumazet@...gle.com, 
 kda@...ux-powerpc.org, cai.huoqing@...ux.dev, dougmill@...ux.ibm.com, 
 npiggin@...il.com, christophe.leroy@...roup.eu, aneesh.kumar@...nel.org, 
 naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com, tlfalcon@...ux.ibm.com, 
 cooldavid@...ldavid.org, marcin.s.wojtas@...il.com, mlindner@...vell.com, 
 stephen@...workplumber.org, nbd@....name, sean.wang@...iatek.com, 
 Mark-MC.Lee@...iatek.com, lorenzo@...nel.org, borisp@...dia.com, 
 bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com, 
 louis.peens@...igine.com, richardcochran@...il.com,
 linux-rdma@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-acenic@...site.dk, linux-net-drivers@....com, 
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 00/15] ethernet: Convert from tasklet to BH workqueue

On Thu, 2024-06-20 at 22:05 -0700, Allen Pais wrote:
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts a few drivers in drivers/ethernet/* from tasklet
> to BH workqueue. The next set will be sent out after the next -rc is
> out.
> 
> This series is based on 
> commit a6ec08beec9e ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")
> 
> First version converting all the drivers can be found at:
> https://lore.kernel.org/all/20240507190111.16710
> -2-apais@...ux.microsoft.com/

The above link was mangled.

I guess you will have to re-submit to cope at least with Andrew's
feedback, but it think it's better to wait a little longer for the next
version, to give the vendors more time to actually test this.

When you will re-submit you can retain the already collected ack.

Please include the target tree ('net-next') in the subj title and a
revision counter ('v3'). The whole subj should be:

[PATCH net-next v3 00/15] ethernet: Convert from tasklet to BH workqueue

Thanks,

Paolo