[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2e78b732-aed7-4de5-b5ac-0da5b78af342@arm.com>
Date: Tue, 25 Jun 2024 13:24:11 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Jie Gan <quic_jiegan@...cinc.com>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Konrad Dybcio <konradybcio@...il.com>, Mike Leach <mike.leach@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Jinlong Mao <quic_jinlmao@...cinc.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, coresight@...ts.linaro.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Tingwei Zhang <quic_tingweiz@...cinc.com>,
Yuanfang Zhang <quic_yuanfang@...cinc.com>,
Tao Zhang <quic_taozha@...cinc.com>, Trilok Soni <quic_tsoni@...cinc.com>,
Song Chai <quic_songchai@...cinc.com>, linux-arm-msm@...r.kernel.org,
andersson@...nel.org, quic_yijiyang@...cinc.com, quic_yuanjiey@...cinc.com,
quic_liuxin@...cinc.com, quic_yanzl@...cinc.com, quic_xinlon@...cinc.com,
quic_xueqnie@...cinc.com, quic_sijiwu@...cinc.com
Subject: Re: [PATCH] Coresight: Set correct cs_mode for TPDM to fix disable
issue
On 25/06/2024 03:12, Jie Gan wrote:
> The coresight_disable_source_sysfs function should verify the
> mode of the coresight device before disabling the source.
> However, the mode for the TPDM device is always set to
> CS_MODE_DISABLED, resulting in the check consistently failing.
> As a result, TPDM cannot be properly disabled.
>
> To fix the issue:
> Configure CS_MODE_SYSFS/CS_MODE_PERF during the enablement of TPDM.
> Configure CS_MODE_DISABLED during the disablement of TPDM.
>
> Fixes: 1f5149c7751c("coresight: Move all sysfs code to sysfs file")
That looks like the wrong commit. This was a problem since the original
TPDM driver. I would say :
Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver")
> Signed-off-by: Jie Gan <quic_jiegan@...cinc.com>
Otherwise, the patch looks good to me.
Please could you also fixup "dummy" source driver in a separate patch.
Suzuki
Powered by blists - more mailing lists