linux-kernel - Re: [PATCH v3 2/4] perf: disasm: use build_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 01:47:54 +0000
From: duchangbin <changbin.du@...wei.com>
To: Namhyung Kim <namhyung@...nel.org>
CC: duchangbin <changbin.du@...wei.com>, Peter Zijlstra
	<peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, "Arnaldo Carvalho de
 Melo" <acme@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Mark Rutland
	<mark.rutland@....com>, Alexander Shishkin
	<alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, "Ian
 Rogers" <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>, Nick Desaulniers
	<ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt
	<justinstitt@...gle.com>, "linux-perf-users@...r.kernel.org"
	<linux-perf-users@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: Re: [PATCH v3 2/4] perf: disasm: use build_id_path if fallback failed

On Mon, Jun 24, 2024 at 05:08:18PM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Tue, Jun 18, 2024 at 09:55:28AM +0800, Changbin Du wrote:
> > If we can not fallback for special dso (vmlinx and vdso), use the
> > build_id_path found previously.
> > 
> > To make change easy, this change first refactors the code by extracting
> > two functions read_buildid_linkname() and fallback_filename().
> 
> Can you please split the refactoring from the actual change?  It'd be
> easier to review and to maintain the code.
> 
Sure, I'll do it taday.

> Thanks,
> Namhyung
> 

-- 
Cheers,
Changbin Du