linux-kernel - Re: [PATCH 02/17] signal: Compute the process exit_code in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240625123415.GA16836@redhat.com>
Date: Tue, 25 Jun 2024 14:34:15 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/17] signal: Compute the process exit_code in get_signal

On 06/18, Eric W. Biederman wrote:
>
> In prepartion for moving the work of sys_exit and sys_group_exit into
> get_signal compute exit_code in get_signal,

So far I don't understand the purpose of this preparation, but

> make PF_SIGNALED depend on the exit_code

> -		current->flags |= PF_SIGNALED;
> +		if (exit_code & 0x7f)
> +			current->flags |= PF_SIGNALED;

This is another user-visible change...

PF_SIGNALED means that the task didn't exit on its own but have gone
through get_signal().

This should not affect coredump_task_exit(), but what about
acct_collect/bacct_add_tsk ?

Confused...

Oleg.