linux-kernel - Re: [PATCH] fbdev: mmp: Constify struct mmp_overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7a209bc9-82bc-4c3b-a9ad-6ee17280b0dc@gmx.de>
Date: Tue, 25 Jun 2024 14:40:53 +0200
From: Helge Deller <deller@....de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev: mmp: Constify struct mmp_overlay_ops

On 6/24/24 21:59, Christophe JAILLET wrote:
> 'struct mmp_overlay_ops' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>    11798	    555	     16	  12369	   3051	drivers/video/fbdev/mmp/hw/mmp_ctrl.o
>
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>    11834	    507	     16	  12357	   3045	drivers/video/fbdev/mmp/hw/mmp_ctrl.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested-only
> ---
>   drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 2 +-
>   include/video/mmp_disp.h              | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)

applied.
Thanks!
Helge