linux-kernel - Re: [PATCH v8 5/7] arm64: dts: qcom: sdm845: Add DT nodes for the TBUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 15:57:38 +0300
From: Georgi Djakov <djakov@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Georgi Djakov <quic_c_gdjako@...cinc.com>
Cc: will@...nel.org, robin.murphy@....com, joro@...tes.org,
 iommu@...ts.linux.dev, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
 robdclark@...il.com, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 quic_cgoldswo@...cinc.com, quic_sukadev@...cinc.com, quic_pdaly@...cinc.com,
 quic_sudaraja@...cinc.com
Subject: Re: [PATCH v8 5/7] arm64: dts: qcom: sdm845: Add DT nodes for the
 TBUs

On 25.06.24 10:50, Dmitry Baryshkov wrote:
> On Fri, 14 Jun 2024 at 21:05, Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
>>
>> On Wed, 17 Apr 2024 at 16:39, Georgi Djakov <quic_c_gdjako@...cinc.com> wrote:
>>>
>>> Add the device-tree nodes for the TBUs (translation buffer units) that
>>> are present on the sdm845 platforms. The TBUs can be used debug the
>>> kernel and provide additional information when a context faults occur.
>>>
>>> Describe the all registers, clocks, interconnects and power-domain
>>> resources that are needed for each of the TBUs.
>>>
>>> Signed-off-by: Georgi Djakov <quic_c_gdjako@...cinc.com>
>>
>> This patch now prevents interconnect drivers from hitting the sync
>> state on SDM845.
>> The TBU driver is enabled only when the ARM_SMMU_QCOM_DEBUG is
>> enabled, which is not a typical case on a normal system:
> 
> Georgi, before I start acting like a bull in a china shop and sending
> reverts, any update from your side?

Hi Dmitry!
Thanks for the report! We can easily add status = "disabled" to the DT
nodes, but please give me some time to take a look what would be the best
way to handle this, as i was out last week and now i am still catching up.

BR,
Georgi

> 
>>
>> [   26.209151] qnoc-sdm845 1500000.interconnect: sync_state() pending
>> due to 150c5000.tbu
>> [   26.217228] qnoc-sdm845 1620000.interconnect: sync_state() pending
>> due to 150c5000.tbu
>> [   26.229926] qnoc-sdm845 1500000.interconnect: sync_state() pending
>> due to 150c9000.tbu
>> [   26.238008] qnoc-sdm845 1620000.interconnect: sync_state() pending
>> due to 150c9000.tbu
>> [   26.249068] qnoc-sdm845 1740000.interconnect: sync_state() pending
>> due to 150cd000.tbu
>> [   26.257127] qnoc-sdm845 1740000.interconnect: sync_state() pending
>> due to 150d1000.tbu
>> [   26.265159] qnoc-sdm845 1740000.interconnect: sync_state() pending
>> due to 150d5000.tbu
>> [   26.273189] qnoc-sdm845 1500000.interconnect: sync_state() pending
>> due to 150d9000.tbu
>> [   26.281206] qnoc-sdm845 1620000.interconnect: sync_state() pending
>> due to 150d9000.tbu
>> [   26.289203] qnoc-sdm845 1500000.interconnect: sync_state() pending
>> due to 150dd000.tbu
>> [   26.297196] qnoc-sdm845 1620000.interconnect: sync_state() pending
>> due to 150dd000.tbu
>> [   26.305201] qnoc-sdm845 1500000.interconnect: sync_state() pending
>> due to 150e1000.tbu
>> [   26.313207] qnoc-sdm845 1620000.interconnect: sync_state() pending
>> due to 150e1000.tbu
>