linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q4lm9dp.wl-tiwai@suse.de>
Date: Tue, 25 Jun 2024 15:37:06 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Gergo Koteles <soyer@....hu>
Cc: Rauty <rautyrauty@...il.com>,
	alsa-devel@...a-project.org,
	tiwai@...e.com,
	perex@...ex.cz,
	kailang@...ltek.com,
	sbinding@...nsource.cirrus.com,
	luke@...nes.dev,
	shenghao-ding@...com,
	simont@...nsource.cirrus.com,
	foss@...aariq.my.id,
	rf@...nsource.cirrus.com,
	wzhd@...c.edu,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Enable headset mic on IdeaPad 330-17IKB 81DM

On Tue, 25 Jun 2024 15:32:16 +0200,
Gergo Koteles wrote:
> 
> Hey Rauty,
> 
> On Mon, 2024-06-24 at 11:25 +0300, Rauty wrote:
> > I haven't changed the patch yet, but it's already in the stable-queue:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.10/alsa-hda-realtek-enable-headset-mic-on-ideapad-330-1.patch
> > Do you still need changes from me?
> 
> I still think this breaks Duet 7 sound, because snd_hda_pick_fixup
> function picks the PCI SSIDs before Codec SSIDs.
> But maybe I missed something.
> 
> Takashi, what do you think?

Hm, a breakage looks possible, indeed.  I naively thought it being a
same model, but this is a different one.

We need an additional codec vendor or SSID check as done for other
machines.


Takashi