linux-kernel - Re: [PATCH] gpio: graniterapids: Add missing raw_spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240625140736.GV1532424@black.fi.intel.com>
Date: Tue, 25 Jun 2024 17:07:36 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Aapo Vienamo <aapo.vienamo@...ux.intel.com>
Cc: Andy Shevchenko <andy@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: graniterapids: Add missing raw_spinlock_init()

On Tue, Jun 25, 2024 at 04:53:43PM +0300, Aapo Vienamo wrote:
> Add the missing raw_spin_lock_init() call to gnr_gpio_probe().
> 
> Fixes: ecc4b1418e23 ("gpio: Add Intel Granite Rapids-D vGPIO driver")
> Signed-off-by: Aapo Vienamo <aapo.vienamo@...ux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Linus/Bartosz, I wonder if you can take this one directly? Andy is
currently on vacation and mine starts after this week so there is nobody
handling these until August. Thanks!

> ---
>  drivers/gpio/gpio-graniterapids.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c
> index c693fe05d50f..f2e911a3d2ca 100644
> --- a/drivers/gpio/gpio-graniterapids.c
> +++ b/drivers/gpio/gpio-graniterapids.c
> @@ -296,6 +296,8 @@ static int gnr_gpio_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> +	raw_spin_lock_init(&priv->lock);
> +
>  	regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(regs))
>  		return PTR_ERR(regs);
> -- 
> 2.45.2