linux-kernel - Re: [PATCH] perf unwind-libunwind: Add malloc() failure handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee434711-e4b1-47cf-a47a-6ba15ec6241d@gmail.com>
Date: Thu, 27 Jun 2024 00:47:47 +0900
From: Yunseong Kim <yskelg@...il.com>
To: Namhyung Kim <namhyung@...nel.org>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Jiri Olsa <jolsa@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>
Cc: kan.liang@...ux.intel.com, Yang Jihong <yangjihong1@...wei.com>,
 Ze Gao <zegao2021@...il.com>, Leo Yan <leo.yan@...ux.dev>,
 Ravi Bangoria <ravi.bangoria@....com>, Austin Kim <austindh.kim@...il.com>,
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
 MichelleJin <shjy180909@...il.com>
Subject: Re: [PATCH] perf unwind-libunwind: Add malloc() failure handling

Hi Namhyung,

On 6/26/24 1:01 오후, Namhyung Kim wrote:
> On Thu, 20 Jun 2024 05:42:12 +0900, yskelg@...il.com wrote:

>> This patch resolve following warning.
>>
>> tools/perf/util/evsel.c:1620:9: error: result of comparison of constant
>> -1 with expression of type 'char' is always false
>>  -Werror,-Wtautological-constant-out-of-range-compare
>>  1620 |                 if (c == -1)
>>       |                     ~ ^  ~~
>>
>> [...]

> Applied to perf-tools-next, thanks!

Thank you!

>> Add malloc() failure handling in unread_unwind_spec_debug_frame().
>> This make caller find_proc_info() works well when the allocation failure.
>>
>>
> 
> Applied to perf-tools-next, thanks!
> 
> Best regards,
> Namhyung


Thank you for applying my patch set.

I've been looking up the feedback you provided earlier and analyzing it
further.

Next time, I will strive to send a more meaningful patch set.


Warm regards,
Yunseong Kim