linux-kernel - Re: [PATCH] drm/amd/display: Add null check before access structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8470f92-8059-46b3-b50d-5ed776d5b087@web.de>
Date: Wed, 26 Jun 2024 18:25:53 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Dillon Varone <dillon.varone@....com>,
 Harry Wentland <harry.wentland@....com>, Jun Lei <jun.lei@....com>,
 Leo Li <sunpeng.li@....com>,
 Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
 Qingqing Zhuo <qingqing.zhuo@....com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Stylon Wang <stylon.wang@....com>, Wayne Lin <Wayne.Lin@....com>,
 Xinhui Pan <Xinhui.Pan@....com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Add null check before access structs

> In enable_phantom_plane, we should better check null pointer before
> accessing various structs.

1. Can a wording approach (like the following) be a better change description?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n45

   A null pointer is stored in the local variable “phantom_plane” after a call
   of the function “create_phantom_plane” (as a data structure menber) failed.
   This pointer was used in subsequent statements where an undesirable
   dereference will be performed then.
   Thus add a corresponding return value check.

2. How do you think about to use a summary phrase like
   “Prevent null pointer dereference in enable_phantom_plane()”?

Regards,
Markus