[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZnxWMB0BJ8H65NE0@slm.duckdns.org>
Date: Wed, 26 Jun 2024 07:56:00 -1000
From: Tejun Heo <tj@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Thomas Gleixner <tglx@...utronix.de>, mingo@...hat.com,
juri.lelli@...hat.com, vincent.guittot@...aro.org,
dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
martin.lau@...nel.org, joshdon@...gle.com, brho@...gle.com,
pjt@...gle.com, derkling@...gle.com, haoluo@...gle.com,
dvernet@...a.com, dschatzberg@...a.com, dskarlat@...cmu.edu,
riel@...riel.com, changwoo@...lia.com, himadrics@...ia.fr,
memxor@...il.com, andrea.righi@...onical.com,
joel@...lfernandes.org, linux-kernel@...r.kernel.org,
bpf@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH sched_ext/for-6.11] sched, sched_ext: Replace
scx_next_task_picked() with sched_class->switch_class()
Hello,
On Wed, Jun 26, 2024 at 10:28:48AM +0200, Peter Zijlstra wrote:
> I suppose I need to read more, because I'm not knowing what cpu_acquire
> is :/ I do know I don't much like the asymmetry here, but maybe it makes
> sense, dunno.
The sched_ext ops are symmetric - ops.cpu_release() is called when SCX loses
CPU to a higher priority sched class and ops.cpu_acquire() when the CPU
returns to SCX afterwards. Where they hook into is not symmetric. The class
which picks the next task already knows the previous task, so there's no
need to add anything. However, without the new sched_class->switch_class(),
the previous class has no way of knowing, so they're a bit different.
Thanks.
--
tejun
Powered by blists - more mailing lists