linux-kernel - Re: [PATCH 2/2] remoteproc: k3-r5: Fix log levels where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 21:00:36 +0200
From: Wadim Egorov <w.egorov@...tec.de>
To: Garrett Giordano <ggiordano@...tec.com>, <andersson@...nel.org>,
	<mathieu.poirier@...aro.org>
CC: <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<upstream@...ts.phytec.de>
Subject: Re: [PATCH 2/2] remoteproc: k3-r5: Fix log levels where appropriate

Hi Garrett,

Am 26.06.24 um 18:22 schrieb Garrett Giordano:
> Driver was logging information as debug. Changed dev_dbg to dev_info
> where appropriate.
> 
> Signed-off-by: Garrett Giordano <ggiordano@...tec.com>
> ---
>   drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> index 50e486bcfa10..5821b6517063 100644
> --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c
> @@ -558,7 +558,7 @@ static int k3_r5_rproc_start(struct rproc *rproc)
>   
>   	boot_addr = rproc->bootaddr;
>   	/* TODO: add boot_addr sanity checking */
> -	dev_dbg(dev, "booting R5F core using boot addr = 0x%x\n", boot_addr);
> +	dev_info(dev, "booting R5F core using boot addr = 0x%x\n", boot_addr);
There is no need for this debug message to be in info level.

Regards,
Wadim
>   
>   	/* boot vector need not be programmed for Core1 in LockStep mode */
>   	core = kproc->core;