linux-kernel - Re: [PATCH] greybus: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 15:18:22 -0500
From: Alex Elder <elder@...e.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, Johan Hovold
 <johan@...nel.org>, Alex Elder <elder@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] greybus: add missing MODULE_DESCRIPTION() macros

On 6/7/24 3:56 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/greybus/greybus.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/greybus/gb-es2.o
> 
> Add all missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>

I would drop the single quotes, but I don't feel very strongly about it.
Greg can offer a second opinion (taking the patch or not).

Acked-by: Alex Elder <elder@...nel.org>

> ---
>   drivers/greybus/core.c | 1 +
>   drivers/greybus/es2.c  | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c
> index 95c09d4f3a86..c28bb973f67c 100644
> --- a/drivers/greybus/core.c
> +++ b/drivers/greybus/core.c
> @@ -375,5 +375,6 @@ static void __exit gb_exit(void)
>   	tracepoint_synchronize_unregister();
>   }
>   module_exit(gb_exit);
> +MODULE_DESCRIPTION("Greybus 'core' driver");
>   MODULE_LICENSE("GPL v2");
>   MODULE_AUTHOR("Greg Kroah-Hartman <gregkh@...uxfoundation.org>");
> diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c
> index 1ee78d0d90b4..db4d033925e6 100644
> --- a/drivers/greybus/es2.c
> +++ b/drivers/greybus/es2.c
> @@ -1456,5 +1456,6 @@ static struct usb_driver es2_ap_driver = {
>   
>   module_usb_driver(es2_ap_driver);
>   
> +MODULE_DESCRIPTION("Greybus 'AP' USB driver for 'ES2' controller chips");
>   MODULE_LICENSE("GPL v2");
>   MODULE_AUTHOR("Greg Kroah-Hartman <gregkh@...uxfoundation.org>");
> 
> ---
> base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
> change-id: 20240607-md-drivers-greybus-a13b64e41256
>