linux-kernel - Re: [PATCH] PM/devfreq: governor: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 21:21:25 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park
	<kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
CC: <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] PM/devfreq: governor: add missing MODULE_DESCRIPTION()
 macros

On 6/5/2024 11:18 AM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_simpleondemand.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_performance.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_powersave.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/devfreq/governor_userspace.o
> 
> Add all missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  drivers/devfreq/governor_performance.c    | 1 +
>  drivers/devfreq/governor_powersave.c      | 1 +
>  drivers/devfreq/governor_simpleondemand.c | 1 +
>  drivers/devfreq/governor_userspace.c      | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
> index 5dbc1e56ec08..2e4e981446fa 100644
> --- a/drivers/devfreq/governor_performance.c
> +++ b/drivers/devfreq/governor_performance.c
> @@ -58,4 +58,5 @@ static void __exit devfreq_performance_exit(void)
>  	return;
>  }
>  module_exit(devfreq_performance_exit);
> +MODULE_DESCRIPTION("DEVFREQ Performance governor");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_powersave.c b/drivers/devfreq/governor_powersave.c
> index 4746af2435b0..f059e8814804 100644
> --- a/drivers/devfreq/governor_powersave.c
> +++ b/drivers/devfreq/governor_powersave.c
> @@ -58,4 +58,5 @@ static void __exit devfreq_powersave_exit(void)
>  	return;
>  }
>  module_exit(devfreq_powersave_exit);
> +MODULE_DESCRIPTION("DEVFREQ Powersave governor");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c
> index d57b82a2b570..c23435736367 100644
> --- a/drivers/devfreq/governor_simpleondemand.c
> +++ b/drivers/devfreq/governor_simpleondemand.c
> @@ -140,4 +140,5 @@ static void __exit devfreq_simple_ondemand_exit(void)
>  	return;
>  }
>  module_exit(devfreq_simple_ondemand_exit);
> +MODULE_DESCRIPTION("DEVFREQ Simple On-demand governor");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
> index d69672ccacc4..d1aa6806b683 100644
> --- a/drivers/devfreq/governor_userspace.c
> +++ b/drivers/devfreq/governor_userspace.c
> @@ -153,4 +153,5 @@ static void __exit devfreq_userspace_exit(void)
>  	return;
>  }
>  module_exit(devfreq_userspace_exit);
> +MODULE_DESCRIPTION("DEVFREQ Userspace governor");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240605-md-drivers-devfreq-42b19b2594a1
> 

Following up to see if anything else is needed from me.
Hoping to see this in linux-next :)

/jeff