linux-kernel - Re: arch/arm/mm/proc.c:82:6: error: conflicting types for 'cpu_arm920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240626210324.GA109435@fedora-macbook-air-m2>
Date: Wed, 26 Jun 2024 14:03:24 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Sami Tolvanen <samitolvanen@...gle.com>
Subject: Re: arch/arm/mm/proc.c:82:6: error: conflicting types for
 'cpu_arm920_reset'

On Wed, Jun 26, 2024 at 10:59:11PM +0200, Linus Walleij wrote:
> On Wed, Jun 26, 2024 at 7:21 PM Nathan Chancellor <nathan@...nel.org> wrote:
> 
> > Hmmm, it seems like the prototypes of the reset functions in
> > arch/arm/mm/proc.c are incorrect? This builds for me with the original
> > configuration and allmodconfig + CONFIG_CFI_CLANG=y.
> 
> Incidentally I fixed it earlier today!
> https://lore.kernel.org/linux-arm-kernel/20240626-arm-proto-regression-v1-1-089c23ea13dd@linaro.org/

Aha, I did not go searching like I normally do to see if a patch was
already sent for it, guess that would have saved me a little time :)

> I added you on Reported-by for now.
> 
> > +void cpu_arm7tdmi_reset(unsigned long addr, bool hvc) __attribute__((noreturn));
> 
> The attribute is not needed on the prototype AFAICT?

I think that in general, noreturn needs to be on prototypes, but for
this prototype/the sake of CFI, I don't think it matters. Sami is free
to correct me though.

Cheers,
Nathan